Remove the non-ARM macOS CI jobs#1946
Merged
Byron merged 2 commits intogitpython-developers:mainfrom Jul 24, 2024
Merged
Conversation
This keeps only the macos-14 jobs, which run on Apple Silicon M1, and removes the macos-13 jobs, which ran on x86-64. Other operating systems jobs continue to run on x86-64 machines (and none on ARM, yet). Only the macOS jobs are removed. This change leaves Python 3.7 without any macOS test job. That is probably okay, since it has been end-of-life for some time, and it remains tested on Ubuntu and Windows.
Currently they are the same. The macos-latest label will move to later versions automatically in the future, like the ubuntu-latest and windows-latest labels that we are already using. In this repo, the macos-14 label had been used originally because it was added before the migration of macos-latest to be macos-14 was completed. See github/roadmap#926. It was kept for clarity of constrast with the macos-13 jobs that were also in use, some for the same Python versions. Now that the macos-13 jobs have been removed in c2bbaf4, the macos-latest label can be used here without confusion.
Byron
approved these changes
Jul 24, 2024
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot, much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps only the
macos-14jobs, which run on Apple Silicon M1, and removes themacos-13jobs, which ran on x86-64. This relates to the commented discussion in #1944. There would also be the option of keeping some of them, but removing all of them decreases the workload the most while also being the simplest.It also uses the label
macos-latestinstead, which is currently equivalent tomacos-14.macos-latestand the benefit of using it is presented in the second commit message.Other operating systems' jobs continue to run on x86-64 machines (and none on ARM, yet). Only macOS jobs are removed.
This change leaves Python 3.7 without any macOS test job. That is probably okay, since it has been end-of-life for some time, and it remains tested on Ubuntu and Windows.